Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Wed, 4 Mar 2020 10:53:38 +0100 | Subject | Re: [PATCH v3] intel_idle: Add Comet Lake support |
| |
On Tue, Mar 3, 2020 at 10:10 AM Harry Pan <harry.pan@intel.com> wrote: > > Add a general C-state table in order to support Comet Lake. > > Signed-off-by: Harry Pan <harry.pan@intel.com> > > --- > > drivers/idle/intel_idle.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c > index d55606608ac8..05bce595fafe 100644 > --- a/drivers/idle/intel_idle.c > +++ b/drivers/idle/intel_idle.c > @@ -1067,6 +1067,11 @@ static const struct idle_cpu idle_cpu_dnv = { > .use_acpi = true, > }; > > +static const struct idle_cpu idle_cpu_cml = { > + .state_table = skl_cstates, > + .disable_promotion_to_c1e = true,
.use_acpi = true,
missing? Otherwise you can just use idle_cpu_skl as is, can't you?
> +}; > + > static const struct x86_cpu_id intel_idle_ids[] __initconst = { > INTEL_CPU_FAM6(NEHALEM_EP, idle_cpu_nhx), > INTEL_CPU_FAM6(NEHALEM, idle_cpu_nehalem), > @@ -1105,6 +1110,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = { > INTEL_CPU_FAM6(ATOM_GOLDMONT_PLUS, idle_cpu_bxt), > INTEL_CPU_FAM6(ATOM_GOLDMONT_D, idle_cpu_dnv), > INTEL_CPU_FAM6(ATOM_TREMONT_D, idle_cpu_dnv), > + INTEL_CPU_FAM6(COMETLAKE_L, idle_cpu_cml), > + INTEL_CPU_FAM6(COMETLAKE, idle_cpu_cml), > {} > }; > > -- > 2.24.1 >
| |