Messages in this thread | | | Date | Tue, 31 Mar 2020 15:04:20 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v4 1/7] tpm: tpm_tis: Make implementation of read16 read32 write32 optional |
| |
On Tue, Mar 31, 2020 at 02:32:01PM +0300, amirmizi6@gmail.com wrote: > From: Amir Mizinski <amirmizi6@gmail.com> > > Only tpm_tis can use memory mapped I/O, which is truly mapped into > the kernel's memory space. So using ioread16/ioread32/iowrite32 turn into a > straightforward pointer dereference. > Every other driver require more complicated operations to read more than 1 > byte at a time and will just fall back to read_bytes/write_bytes. > Therefore, move this common code out of tpm_tis_spi into tpm_tis_core, so > that it is automatically used when low-level drivers do not implement the > specialized methods. > > Co-developed-by: Alexander Steffen <Alexander.Steffen@infineon.com> > Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com> > Signed-off-by: Amir Mizinski <amirmizi6@gmail.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
| |