lkml.org 
[lkml]   [2020]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 02/13] Documentation: mfd: Add DT bindings for i.MX Audiomix
    On Wed, Mar 25, 2020 at 05:38:40PM +0200, Abel Vesa wrote:
    > The i.MX Audiomix is a mix of clock gates, reset bits
    > and some other i.MX audio specific functionalities.
    > Add information for the MFD, its clock and reset controllers.
    >
    > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
    > ---
    > .../devicetree/bindings/mfd/fsl,imx-audiomix.txt | 34 ++++++++++++++++++++++
    > 1 file changed, 34 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/mfd/fsl,imx-audiomix.txt

    Please use DT schema format.

    > diff --git a/Documentation/devicetree/bindings/mfd/fsl,imx-audiomix.txt b/Documentation/devicetree/bindings/mfd/fsl,imx-audiomix.txt
    > new file mode 100644
    > index 00000000..1622818
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/mfd/fsl,imx-audiomix.txt
    > @@ -0,0 +1,34 @@
    > +Freescale i.MX Audiomix
    > +======================================
    > +
    > +Audiomix is a conglomerate of different functionalities.
    > +
    > +Required properties:
    > +- compatible: Should be "fsl,<chip>-mix" for the MFD device
    > + Should be"fsl,<chip>-audiomix-clk" for the clock controller
    > + Should be"fsl,<chip>-audiomix-reset" for the reset controller
    > + Some functionalities of the audiomix will be registered as syscon.
    > +- reg: should be register base and length as documented in the
    > + datasheet
    > +
    > +example:
    > + audiomix: audiomix@30e20000 {
    > + compatible = "fsl,imx8mp-mix";
    > + reg = <0x30e20000 0x10000>;
    > +
    > + audiomix_clk: clock-controller {
    > + compatible = "fsl,imx8mp-audiomix-clk";
    > + #clock-cells = <1>;
    > + clocks = <&clk IMX8MP_CLK_AUDIO_ROOT>,
    > + <&clk IMX8MP_CLK_AUDIO_AHB>,
    > + <&clk IMX8MP_CLK_AUDIO_AXI_DIV>;

    None of these clocks are needed for the other functions in this MFD.

    I'm not all that convinced that these child nodes are needed. A single
    node can be a clock and reset provider. If you have other things to add
    to the binding, do so now even if you don't have driver support.

    > + clock-names = "audio_root",
    > + "audio_ahb",
    > + "audio_axi_div";
    > + };
    > +
    > + audiomix_reset: reset-controller {
    > + compatible = "fsl,imx8mp-audiomix-reset";
    > + #reset-cells = <1>;
    > + };
    > + };
    > --
    > 2.7.4
    >

    \
     
     \ /
      Last update: 2020-03-31 23:55    [W:4.067 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site