lkml.org 
[lkml]   [2020]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 08/12] pwm: stm32-lp: Use %llu format specifier for period
On Fri, Mar 20, 2020 at 03:45:35AM -0700, Joe Perches wrote:
> On Thu, 2020-03-19 at 18:41 -0700, Guru Das Srinagesh wrote:
> > Since the PWM framework is switching struct pwm_args.period's
> > datatype to u64, prepare for this transition by using the right
> > specifier for printing a 64-bit value.
> []
> > diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c
> []
> > @@ -61,7 +61,7 @@ static int stm32_pwm_lp_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> > do_div(div, NSEC_PER_SEC);
> > if (!div) {
> > /* Clock is too slow to achieve requested period. */
> > - dev_dbg(priv->chip.dev, "Can't reach %u ns\n", state->period);
> > + dev_dbg(priv->chip.dev, "Can't reach %llu ns\n", state->period);
> > return -EINVAL;
> > }
>
> Doesn't this introduce a warning now without the
> actual change to the type of state->period?

You're right, it does.

> Likely these patches should either not be separated
> or this should also use a cast to avoid introducing
> intermediate compilation warnings.

Only this patch has this specific issue, so I'll squish it with the
final patch in this series ("pwm: core: Convert period and duty cycle to
u64") that modifies the framework structs. Thanks for pointing this out.

Thank you.

Guru Das.

\
 
 \ /
  Last update: 2020-03-30 21:30    [W:0.036 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site