Messages in this thread | | | Date | Mon, 30 Mar 2020 10:55:51 -0700 (PDT) | Subject | Re: [PATCH] net: dsa: Simplify 'dsa_tag_protocol_to_str()' | From | David Miller <> |
| |
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Date: Sat, 28 Mar 2020 10:53:09 +0100
> There is no point in preparing the module name in a buffer. The format > string can be passed diectly to 'request_module()'. > > This axes a few lines of code and cleans a few things: > - max len for a driver name is MODULE_NAME_LEN wich is ~ 60 chars, > not 128. It would be down-sized in 'request_module()' > - we should pass the total size of the buffer to 'snprintf()', not the > size minus 1 > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied to net-next.
| |