Messages in this thread | | | From | "Kaneda, Erik" <> | Subject | RE: [PATCH -next] ACPICA: Make acpi_protocol_lengths static | Date | Mon, 30 Mar 2020 17:52:23 +0000 |
| |
> -----Original Message----- > From: linux-acpi-owner@vger.kernel.org <linux-acpi- > owner@vger.kernel.org> On Behalf Of Rafael J. Wysocki > Sent: Saturday, March 28, 2020 2:14 AM > To: YueHaibing <yuehaibing@huawei.com>; Moore, Robert > <robert.moore@intel.com>; Kaneda, Erik <erik.kaneda@intel.com> > Cc: Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Len Brown > <lenb@kernel.org>; ACPI Devel Maling List <linux-acpi@vger.kernel.org>; > open list:ACPI COMPONENT ARCHITECTURE (ACPICA) <devel@acpica.org>; > Linux Kernel Mailing List <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH -next] ACPICA: Make acpi_protocol_lengths static > > On Sat, Mar 28, 2020 at 4:47 AM YueHaibing <yuehaibing@huawei.com> > wrote: > > > > Fix sparse warning: > > > > drivers/acpi/acpica/exfield.c:25:10: warning: > > symbol 'acpi_protocol_lengths' was not declared. Should it be static?
I don’t understand what sparse is trying to say here. This variable is declared in exfield.c... Could you provide more details on this sparse warning?
Erik
> > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Bob, Erik, I'm leaving this one to you. > > > --- > > drivers/acpi/acpica/exfield.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/acpica/exfield.c > > b/drivers/acpi/acpica/exfield.c index e85eb31e5075..3323a2ba6a31 > > 100644 > > --- a/drivers/acpi/acpica/exfield.c > > +++ b/drivers/acpi/acpica/exfield.c > > @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield") > > */ > > #define ACPI_INVALID_PROTOCOL_ID 0x80 > > #define ACPI_MAX_PROTOCOL_ID 0x0F > > -const u8 acpi_protocol_lengths[] = { > > +static const u8 acpi_protocol_lengths[] = { > > ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */ > > ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */ > > 0x00, /* 2 - ATTRIB_QUICK */ > > -- > > 2.17.1 > > > >
| |