Messages in this thread | | | Date | Mon, 30 Mar 2020 18:24:14 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: mdio: of: Do not treat fixed-link as PHY |
| |
On Mon, Mar 30, 2020 at 05:21:30PM +0100, Russell King - ARM Linux admin wrote: > On Mon, Mar 30, 2020 at 06:17:40PM +0200, Andrew Lunn wrote: > > On Mon, Mar 30, 2020 at 07:01:36PM +0300, Codrin Ciubotariu wrote: > > > Some ethernet controllers, such as cadence's macb, have an embedded MDIO. > > > For this reason, the ethernet PHY nodes are not under an MDIO bus, but > > > directly under the ethernet node. > > > > Hi Codrin > > > > That is deprecated. It causes all sorts of problems putting PHY nodes > > in the MAC without a container. > > > > Please fix macb to look for an mdio node, and place your fixed link > > inside it. > > Seems wrong.
Hi Russell
Gerr. You are right.
> fixed links have never needed to be under a mdio node - see > Documentation/devicetree/bindings/net/ethernet-controller.yaml
macb does crazy stuff. I will take another look.
Andrew
| |