lkml.org 
[lkml]   [2020]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] perf build-test: Honour JOBS to override detection of
On Mon, Mar 30, 2020 at 10:03:01AM -0300, Arnaldo Carvalho de Melo wrote:
> Jiri,
>
> Ack?

yep ;-)

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

>
> ----
>
> When one does:
>
> $ make -C tools/perf build-test
>
> The makefile in tools/perf/tests/ will, just like the main one, detect
> how many cores are in the system and use it with -j.
>
> Sometimes we may need to override that, for instance, when using
> icecream or distcc to use multiple machines in the build process, then
> we need to, as with the main makefile, use:
>
> $ make JOBS=N -C tools/perf build-test
>
> Fix the tests makefile to honour that.
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/tests/make | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index c850d1664c56..5d0c3a9c47a1 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -28,9 +28,13 @@ endif
>
> PARALLEL_OPT=
> ifeq ($(SET_PARALLEL),1)
> - cores := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null)
> - ifeq ($(cores),0)
> - cores := 1
> + ifeq ($(JOBS),)
> + cores := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null)
> + ifeq ($(cores),0)
> + cores := 1
> + endif
> + else
> + cores=$(JOBS)
> endif
> PARALLEL_OPT="-j$(cores)"
> endif
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2020-03-30 15:17    [W:0.031 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site