lkml.org 
[lkml]   [2020]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] mm/page_alloc: Enumerate bad page reasons
From
Date
On 30.03.20 08:51, Anshuman Khandual wrote:
> Enumerate all existing bad page reasons which can be used in bad_page() for
> reporting via __dump_page(). Unfortunately __dump_page() cannot be changed.
> __dump_page() is called from dump_page() that accepts a raw string and is
> also an exported symbol that is currently being used from various generic
> memory functions and other drivers. This reduces code duplication while
> reporting bad pages.

Yeah sounds nice, but "56 insertions(+), 20 deletions(-)" does not sound
so nice ... and the "code duplication" is actually "repeating strings".

... I don't think we want/need this.

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2020-03-30 10:45    [W:0.067 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site