lkml.org 
[lkml]   [2020]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC 2/3] mm/vma: Introduce VM_ACCESS_FLAGS
    From
    Date
    On 3/2/20 7:47 AM, Anshuman Khandual wrote:
    > There are many places where all basic VMA access flags (read, write, exec)
    > are initialized or checked against as a group. One such example is during
    > page fault. Existing vma_is_accessible() wrapper already creates the notion
    > of VMA accessibility as a group access permissions. Hence lets just create
    > VM_ACCESS_FLAGS (VM_READ|VM_WRITE|VM_EXEC) which will not only reduce code
    > duplication but also extend the VMA accessibility concept in general.
    >
    > Cc: Russell King <linux@armlinux.org.uk>
    > CC: Catalin Marinas <catalin.marinas@arm.com>
    > CC: Mark Salter <msalter@redhat.com>
    > Cc: Nick Hu <nickhu@andestech.com>
    > CC: Ley Foon Tan <ley.foon.tan@intel.com>
    > Cc: Michael Ellerman <mpe@ellerman.id.au>
    > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
    > Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
    > Cc: Guan Xuetao <gxt@pku.edu.cn>
    > Cc: Dave Hansen <dave.hansen@linux.intel.com>
    > Cc: Thomas Gleixner <tglx@linutronix.de>
    > Cc: Rob Springer <rspringer@google.com>
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > Cc: linux-arm-kernel@lists.infradead.org
    > Cc: linux-c6x-dev@linux-c6x.org
    > Cc: nios2-dev@lists.rocketboards.org
    > Cc: linuxppc-dev@lists.ozlabs.org
    > Cc: linux-s390@vger.kernel.org
    > Cc: linux-sh@vger.kernel.org
    > Cc: devel@driverdev.osuosl.org
    > Cc: linux-mm@kvack.org
    > Cc: linux-kernel@vger.kernel.org
    > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>

    Dunno. Such mask seems ok for testing flags, but it's a bit awkward when
    initializing flags, where it covers just one of many combinations that seem
    used. But no strong opinions, patch looks correct.

    \
     
     \ /
      Last update: 2020-03-03 18:50    [W:3.480 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site