lkml.org 
[lkml]   [2020]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 132/176] net: atlantic: fix out of range usage of active_vlans array
    Date
    From: Dmitry Bogdanov <dbogdanov@marvell.com>

    commit 5a292c89a84d49b598f8978f154bdda48b1072c0 upstream.

    fix static checker warning:
    drivers/net/ethernet/aquantia/atlantic/aq_filters.c:166 aq_check_approve_fvlan()
    error: passing untrusted data to 'test_bit()'

    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Fixes: 7975d2aff5af: ("net: aquantia: add support of rx-vlan-filter offload")
    Signed-off-by: Dmitry Bogdanov <dbogdanov@marvell.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/ethernet/aquantia/atlantic/aq_filters.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/aquantia/atlantic/aq_filters.c
    +++ b/drivers/net/ethernet/aquantia/atlantic/aq_filters.c
    @@ -163,7 +163,7 @@ aq_check_approve_fvlan(struct aq_nic_s *
    }

    if ((aq_nic->ndev->features & NETIF_F_HW_VLAN_CTAG_FILTER) &&
    - (!test_bit(be16_to_cpu(fsp->h_ext.vlan_tci),
    + (!test_bit(be16_to_cpu(fsp->h_ext.vlan_tci) & VLAN_VID_MASK,
    aq_nic->active_vlans))) {
    netdev_err(aq_nic->ndev,
    "ethtool: unknown vlan-id specified");

    \
     
     \ /
      Last update: 2020-03-03 19:10    [W:4.024 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site