lkml.org 
[lkml]   [2020]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 094/152] MIPS: VPE: Fix a double free and a memory leak in release_vpe()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit bef8e2dfceed6daeb6ca3e8d33f9c9d43b926580 upstream.

    Pointer on the memory allocated by 'alloc_progmem()' is stored in
    'v->load_addr'. So this is this memory that should be freed by
    'release_progmem()'.

    'release_progmem()' is only a call to 'kfree()'.

    With the current code, there is both a double free and a memory leak.
    Fix it by passing the correct pointer to 'release_progmem()'.

    Fixes: e01402b115ccc ("More AP / SP bits for the 34K, the Malta bits and things. Still wants")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Paul Burton <paulburton@kernel.org>
    Cc: ralf@linux-mips.org
    Cc: linux-mips@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: kernel-janitors@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/mips/kernel/vpe.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/mips/kernel/vpe.c
    +++ b/arch/mips/kernel/vpe.c
    @@ -134,7 +134,7 @@ void release_vpe(struct vpe *v)
    {
    list_del(&v->list);
    if (v->load_addr)
    - release_progmem(v);
    + release_progmem(v->load_addr);
    kfree(v);
    }


    \
     
     \ /
      Last update: 2020-03-03 18:58    [W:3.060 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site