lkml.org 
[lkml]   [2020]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 03/13] iio: st_sensors_spi: Use vsprintf extension %pe for symbolic error name
    On Sun, 22 Mar 2020 22:53:05 +0530
    Nishant Malpani <nish.malpani25@gmail.com> wrote:

    > Utilize %pe format specifier from vsprintf while printing error logs
    > with dev_err(). Discards the use of unnecessary explicit casting and
    > prints symbolic error name which might prove to be convenient during
    > debugging.
    >
    > Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>
    Same comment as for the previous patch.

    Thanks,

    J
    > ---
    >
    > Changes in v2:
    > - Rewrite commit subject line outlining the usage of %pe.
    > - Add a separator between regmap and its error name.
    >
    > Based on conversations in [1] & [2].
    >
    > [1] https://marc.info/?l=linux-iio&m=158427554607223&w=2
    > [2] https://marc.info/?l=linux-iio&m=158481647605891&w=2
    > ---
    > drivers/iio/common/st_sensors/st_sensors_spi.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/iio/common/st_sensors/st_sensors_spi.c b/drivers/iio/common/st_sensors/st_sensors_spi.c
    > index 1275fb0eda31..efa93928b498 100644
    > --- a/drivers/iio/common/st_sensors/st_sensors_spi.c
    > +++ b/drivers/iio/common/st_sensors/st_sensors_spi.c
    > @@ -101,8 +101,8 @@ int st_sensors_spi_configure(struct iio_dev *indio_dev,
    >
    > sdata->regmap = devm_regmap_init_spi(spi, config);
    > if (IS_ERR(sdata->regmap)) {
    > - dev_err(&spi->dev, "Failed to register spi regmap (%d)\n",
    > - (int)PTR_ERR(sdata->regmap));
    > + dev_err(&spi->dev, "Failed to register spi regmap: %pe\n",
    > + sdata->regmap);
    > return PTR_ERR(sdata->regmap);
    > }
    >

    \
     
     \ /
      Last update: 2020-03-28 15:13    [W:4.066 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site