Messages in this thread | | | From | Arnaldo Carvalho de Melo <> | Date | Fri, 27 Mar 2020 13:35:43 -0300 | Subject | Re: [PATCH 8/9] perf top: Add --all-cgroups option |
| |
Em Wed, Mar 25, 2020 at 09:45:35PM +0900, Namhyung Kim escreveu: > The --all-cgroups option is to enable cgroup profiling support. It > tells kernel to record CGROUP events in the ring buffer so that perf > report can identify task/cgroup association later. s/report/top/g in this case, and I added:
Committer testing:
Use:
# perf top --all-cgroups -s cgroup_id,cgroup,pid
- Arnaldo
> Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/Documentation/perf-top.txt | 4 ++++ > tools/perf/builtin-top.c | 9 +++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt > index 324b6b53c86b..ddab103af8c7 100644 > --- a/tools/perf/Documentation/perf-top.txt > +++ b/tools/perf/Documentation/perf-top.txt > @@ -272,6 +272,10 @@ Default is to monitor all CPUS. > Record events of type PERF_RECORD_NAMESPACES and display it with the > 'cgroup_id' sort key. > > +--all-cgroups:: > + Record events of type PERF_RECORD_CGROUP and display it with the > + 'cgroup' sort key. > + > --switch-on EVENT_NAME:: > Only consider events after this event is found. > > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c > index d2539b793f9d..56b2dd0db88e 100644 > --- a/tools/perf/builtin-top.c > +++ b/tools/perf/builtin-top.c > @@ -1246,6 +1246,8 @@ static int __cmd_top(struct perf_top *top) > > if (opts->record_namespaces) > top->tool.namespace_events = true; > + if (opts->record_cgroup) > + top->tool.cgroup_events = true; > > ret = perf_event__synthesize_bpf_events(top->session, perf_event__process, > &top->session->machines.host, > @@ -1253,6 +1255,11 @@ static int __cmd_top(struct perf_top *top) > if (ret < 0) > pr_debug("Couldn't synthesize BPF events: Pre-existing BPF programs won't have symbols resolved.\n"); > > + ret = perf_event__synthesize_cgroups(&top->tool, perf_event__process, > + &top->session->machines.host); > + if (ret < 0) > + pr_debug("Couldn't synthesize cgroup events.\n"); > + > machine__synthesize_threads(&top->session->machines.host, &opts->target, > top->evlist->core.threads, false, > top->nr_threads_synthesize); > @@ -1545,6 +1552,8 @@ int cmd_top(int argc, const char **argv) > "number of thread to run event synthesize"), > OPT_BOOLEAN(0, "namespaces", &opts->record_namespaces, > "Record namespaces events"), > + OPT_BOOLEAN(0, "all-cgroups", &opts->record_cgroup, > + "Record cgroup events"), > OPTS_EVSWITCH(&top.evswitch), > OPT_END() > }; > -- > 2.25.1.696.g5e7596f4ac-goog >
--
- Arnaldo
| |