Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 27 Mar 2020 11:28:38 +0100 | Subject | Re: [PATCH v2] irqchip/versatile-fpga: Handle chained IRQs properly |
| |
On Thu, Mar 19, 2020 at 3:36 AM Sungbo Eo <mans0n@gorani.run> wrote:
> Enclose the chained handler with chained_irq_{enter,exit}(), so that the > muxed interrupts get properly acked. > > This patch also fixes a reboot bug on OX820 SoC, where the jiffies timer > interrupt is never acked. The kernel waits a clock tick forever in > calibrate_delay_converge(), which leads to a boot hang. > > Fixes: c41b16f8c9d9 ("ARM: integrator/versatile: consolidate FPGA IRQ handling code") > Signed-off-by: Sungbo Eo <mans0n@gorani.run> > Cc: Neil Armstrong <narmstrong@baylibre.com> > --- > v2: moved readl below chained_irq_enter() > added Fixes tag
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I wonder how Integrator keeps working so well despite this. I can't test it right now but I'm sure it is fine.
Yours, Linus Walleij
| |