Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] powerpc/maple: Fix declaration made after definition | Date | Thu, 26 Mar 2020 23:07:02 +1100 (AEDT) |
| |
On Mon, 2020-03-23 at 22:27:29 UTC, Nathan Chancellor wrote: > When building ppc64 defconfig, Clang errors (trimmed for brevity): > > arch/powerpc/platforms/maple/setup.c:365:1: error: attribute declaration > must precede definition [-Werror,-Wignored-attributes] > machine_device_initcall(maple, maple_cpc925_edac_setup); > ^ > > machine_device_initcall expands to __define_machine_initcall, which in > turn has the macro machine_is used in it, which declares mach_##name > with an __attribute__((weak)). define_machine actually defines > mach_##name, which in this file happens before the declaration, hence > the warning. > > To fix this, move define_machine after machine_device_initcall so that > the declaration occurs before the definition, which matches how > machine_device_initcall and define_machine work throughout arch/powerpc. > > While we're here, remove some spaces before tabs. > > Fixes: 8f101a051ef0 ("edac: cpc925 MC platform device setup") > Link: https://godbolt.org/z/kDoYSA > Link: https://github.com/ClangBuiltLinux/linux/issues/662 > Reported-by: Nick Desaulniers <ndesaulniers@google.com> > Suggested-by: Ilie Halip <ilie.halip@gmail.com> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/af6cf95c4d003fccd6c2ecc99a598fb854b537e7
cheers
| |