lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 02/27] ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts
On Tue, Mar 17, 2020 at 03:43:08PM +0100, Bartlomiej Zolnierkiewicz wrote:
> There is no point in exposing ncq_enable_prio sysfs attribute for
> devices on PATA and non-NCQ capable SATA hosts so:
>
> * remove dev_attr_ncq_prio_enable from ata_common_sdev_attrs[]
>
> * add ata_ncq_sdev_attrs[]
>
> * update ATA_NCQ_SHT() macro to use ata_ncq_sdev_attrs[]
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

\
 
 \ /
  Last update: 2020-03-26 10:47    [W:0.168 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site