Messages in this thread Patch in this message | | | From | Yoshihiro Shimoda <> | Subject | RE: [PATCH v2 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema | Date | Fri, 27 Mar 2020 02:42:03 +0000 |
| |
Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Thursday, March 26, 2020 6:00 PM <snip> > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > > @@ -0,0 +1,103 @@ > > +# SPDX-License-Identifier: GPL-2.0-only
> I think Rob would prefer to see > > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
I'll fix it.
> > + reg: > > + # base address and length of the registers block for the PHY. > > The comment is not needed.
OK. I'll remove it.
> > + maxItems: 1 > > + > > + clocks: > > + # clock phandle and specifier pair(s). > > Likewise.
I got it.
> > + minItems: 1 > > + maxItems: 2 > > + > > + clock-names: > > + # for RZ/A2 > > if: > properties: > compatible: > items: > enum: > - renesas,usb2-phy-r7s9210
Thank you for the proposal. I'll fix it.
> > + minItems: 1 > > + maxItems: 2 > > + items: > > + - const: fck > > + - const: usb_x1 > > > +examples: > > + - | > > + #include <dt-bindings/clock/r8a7795-cpg-mssr.h> > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/power/r8a7795-sysc.h> > > + > > + usb-phy@ee080200 { > > + compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy"; > > + reg = <0 0xee080200 0 0x700>; > > Examples are built with #{address,size}-cells = <1>, so > > reg = <0xee080200 0x700>;
I got it. I'll fix it.
> > + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 703>; > > + #phy-cells = <1>; > > + }; > > + > > + usb-phy@ee0a0200 { > > + compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy"; > > + reg = <0 0xee0a0200 0 0x700>; > > reg = <0xee0a0200 0x700>;
Yes, I'll fix it.
Best regards, Yoshihiro Shimoda
| |