lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/2] tty: serial: fsl_lpuart: fix return value checking
    Date
    The return value of lpuart_dma_tx_request() is an negative errno on
    failure and zero on success.

    Fixes: 159381df1442f ("tty: serial: fsl_lpuart: fix DMA operation when using IOMMU")
    Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
    Signed-off-by: Michael Walle <michael@walle.cc>
    ---
    changes since v1:
    - none

    drivers/tty/serial/fsl_lpuart.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
    index 131018979b77..5d41075964f2 100644
    --- a/drivers/tty/serial/fsl_lpuart.c
    +++ b/drivers/tty/serial/fsl_lpuart.c
    @@ -1538,7 +1538,7 @@ static void lpuart_tx_dma_startup(struct lpuart_port *sport)
    goto err;

    ret = lpuart_dma_tx_request(&sport->port);
    - if (!ret)
    + if (ret)
    goto err;

    init_waitqueue_head(&sport->dma_wait);
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-03-25 10:07    [W:3.517 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site