Messages in this thread | | | Date | Tue, 24 Mar 2020 09:35:50 +0100 | From | Morten Rasmussen <> | Subject | Re: [RFC PATCH 1/3] sched/topology: Split out SD_* flags declaration to its own file |
| |
On Mon, Mar 23, 2020 at 05:10:00PM +0000, Valentin Schneider wrote: > > Hi Morten, > > Just as a heads-up, I think those changes would better fit 2/3, or be > in their own patch. 1/3 is just a straight up code move, with no changes > to the existing comments.
I realized that when I got to 2/3, and yes, most of the comments are not really related to your proposal it more things we could fix while we are touching that code anyway.
> On Mon, Mar 23 2020, Morten Rasmussen wrote: > > On Wed, Mar 11, 2020 at 06:33:18PM +0000, Valentin Schneider wrote: > >> +/* Domain members share power domain */ > >> +SD_FLAG(SD_SHARE_POWERDOMAIN, 7) > > > > This flag is set only by 32-bit arm and has never had any effect. I > > think it was the beginning of something years ago that hasn't > > progressed. Perhaps we can remove it now? > > > > Right, I don't think I've seen anything recent that uses that flag.
AFAIK, it has never been used, only set.
Morten
| |