Messages in this thread | | | Subject | Re: [PATCH] platform/chrome: wilco_ec: Provide correct output format to 'h1_gpio' file | From | Enric Balletbo i Serra <> | Date | Tue, 24 Mar 2020 14:54:51 +0100 |
| |
Hi,
On 23/3/20 21:06, Daniel Campello wrote: > Hello, > > On Tue, Mar 17, 2020 at 1:09 AM Enric Balletbo i Serra > <enric.balletbo@collabora.com> wrote: >> >> Hi, >> >> On 14/3/20 0:27, Bernardo Perez Priego wrote: >>> Function 'h1_gpio_get' is receiving 'val' parameter of type u64, >>> this is being passed to 'send_ec_cmd' as type u8, thus, result >>> is stored in least significant byte. Due to output format, >>> the whole 'val' value was being displayed when any of the most >>> significant bytes are different than zero. >>> >>> This fix will make sure only least significant byte is displayed >>> regardless of remaining bytes value. >>> >>> Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego@intel.com> >> >> Daniel, could you give a try and give you Tested-by tag if you're fine with it? >> >> Thanks, >> Enric >> >>> --- >>> drivers/platform/chrome/wilco_ec/debugfs.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c b/drivers/platform/chrome/wilco_ec/debugfs.c >>> index df5a5f6c3ec6..c775b7d58c6d 100644 >>> --- a/drivers/platform/chrome/wilco_ec/debugfs.c >>> +++ b/drivers/platform/chrome/wilco_ec/debugfs.c >>> @@ -211,7 +211,7 @@ static int h1_gpio_get(void *arg, u64 *val) >>> return send_ec_cmd(arg, SUB_CMD_H1_GPIO, (u8 *)val); >>> } >>> >>> -DEFINE_DEBUGFS_ATTRIBUTE(fops_h1_gpio, h1_gpio_get, NULL, "0x%02llx\n"); >>> +DEFINE_DEBUGFS_ATTRIBUTE(fops_h1_gpio, h1_gpio_get, NULL, "0x%02hhx\n"); >>> >>> /** >>> * test_event_set() - Sends command to EC to cause an EC test event. >>> > > Done. I also found the chromium review for this on crrev.com/c/2090128 > > Tested-by: Daniel Campello <campello@chromium.org> >
Queued for 5.7. Thanks.
~ Enric
| |