Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 23 Mar 2020 11:53:39 -0700 | Subject | Re: [RFC][PATCH 13/22] x86: ia32_setup_sigcontext(): lift user_access_{begin,end}() into the callers |
| |
On Mon, Mar 23, 2020 at 11:39 AM Al Viro <viro@zeniv.linux.org.uk> wrote: > > -static int ia32_setup_sigcontext(struct sigcontext_32 __user *sc, > +static __always_inline int ia32_setup_sigcontext(struct sigcontext_32 __user *sc,
Please rename this at the same time (to "unsafe_ia32_setup_sigcontext()").
I absolutely _hate_ how we have historically split the "__get_user()" calls from the "access_ok()" calls, and then have had bugs when we had ways to reach the user access without checking it.
Yes, we have static checking for the unsafe stuff in objtool now, but I still want this to be explicit on the source level too: if you do unsafe user accesses, you make it very very explicit in the naming, so that you can't possibly even by mistake have a "let's call this function withou having done the user_access_begin()" calls.
Linus
| |