Messages in this thread | | | Date | Fri, 20 Mar 2020 22:16:12 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH 2/4] clk: qcom: mmcc-msm8996: Properly describe GPU_GX gdsc |
| |
On Fri 20 Mar 16:31 PDT 2020, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2020-03-18 22:39:00) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > index 85518494ce43..65d9aa790581 100644 > > --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > @@ -67,6 +67,10 @@ properties: > > description: > > Protected clock specifier list as per common clock binding > > > > + vdd_gfx-supply: > > Why not vdd-gfx-supply? What's with the underscore? >
The pad is named "VDD_GFX" in the datasheet and the schematics. I see that we've started y/_/-/ in some of the newly added bindings, would you prefer I follow this?
Regards, Bjorn
> > + description: > > + Regulator supply for the GPU_GX GDSC > > + > > required: > > - compatible > > - reg
| |