Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch V2 07/15] powerpc/ps3: Convert half completion to rcuwait | Date | Sat, 21 Mar 2020 11:41:42 +0100 |
| |
Christoph Hellwig <hch@infradead.org> writes:
> On Wed, Mar 18, 2020 at 09:43:09PM +0100, Thomas Gleixner wrote: >> The PS3 notification interrupt and kthread use a hacked up completion to >> communicate. Since we're wanting to change the completion implementation and >> this is abuse anyway, replace it with a simple rcuwait since there is only ever >> the one waiter. >> >> AFAICT the kthread uses TASK_INTERRUPTIBLE to not increase loadavg, kthreads >> cannot receive signals by default and this one doesn't look different. Use >> TASK_IDLE instead. > > I think the right fix here is to jut convert the thing to a threaded > interrupt handler and kill off the stupid kthread.
That'd be a major surgery.
> But I wonder how alive the whole PS3 support is to start with..
There seem to be a few enthusiast left which have a Other-OS capable PS3
Thanks,
tglx
| |