Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 20 Mar 2020 10:10:24 +0100 | Subject | Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio |
| |
Hi Alex,
On Fri, Mar 20, 2020 at 9:58 AM Alex Riesen <alexander.riesen@cetitec.com> wrote: > Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > > > +int adv748x_dai_init(struct adv748x_dai *dai) > > > +{ > > > + int ret; > > > + struct adv748x_state *state = adv748x_dai_to_state(dai); > > > + > > > + dai->mclk = clk_register_fixed_rate(state->dev, > > > + "adv748x-hdmi-i2s-mclk", > > > > I assume there can be multiple adv748x instances in the system? > > Hence the clock name should be unique for each instance. > > I think that can happen. > > Is it alright to derive the clock name from the device name? E.g.: > adv748x.4-0070-mclk? Where "adv748x.4-0070" is a struct device->name.
Yes, that's the idea.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |