Messages in this thread | | | Subject | Re: [PATCH v4 03/11] drm/bridge: dw-hdmi: Plug atomic state hooks to the default implementation | From | Neil Armstrong <> | Date | Mon, 2 Mar 2020 16:55:49 +0100 |
| |
On 02/03/2020 10:56, Laurent Pinchart wrote: > Hi Neil, > > Thank you for the patch. > > On Thu, Feb 06, 2020 at 08:18:26PM +0100, Neil Armstrong wrote: >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > > How about adding a commit message ?
Done, thanks
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> index 051001f77dd4..fec4a4bcd1fe 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> @@ -2494,6 +2494,9 @@ static void dw_hdmi_bridge_enable(struct drm_bridge *bridge) >> } >> >> static const struct drm_bridge_funcs dw_hdmi_bridge_funcs = { >> + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, >> + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, >> + .atomic_reset = drm_atomic_helper_bridge_reset, >> .attach = dw_hdmi_bridge_attach, >> .detach = dw_hdmi_bridge_detach, >> .enable = dw_hdmi_bridge_enable, >
| |