lkml.org 
[lkml]   [2020]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 64/93] batman-adv: Fix rx packet/bytes stats on local ARP reply
    Date
    From: Sven Eckelmann <sven@narfation.org>

    commit 36d4d68cd658d914ef73ac845705c4a89e7d9e2f upstream.

    The stats are generated by batadv_interface_stats and must not be stored
    directly in the net_device stats member variable. The batadv_priv
    bat_counters information is assembled when ndo_get_stats is called. The
    stats previously stored in net_device::stats is then overwritten.

    The batman-adv counters must therefore be increased when an ARP packet is
    answered locally via the distributed arp table.

    Fixes: c384ea3ec930 ("batman-adv: Distributed ARP Table - add snooping functions for ARP messages")
    Signed-off-by: Sven Eckelmann <sven@narfation.org>
    Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
    Signed-off-by: Sven Eckelmann <sven@narfation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/batman-adv/distributed-arp-table.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/net/batman-adv/distributed-arp-table.c
    +++ b/net/batman-adv/distributed-arp-table.c
    @@ -1003,8 +1003,9 @@ bool batadv_dat_snoop_outgoing_arp_reque
    skb_reset_mac_header(skb_new);
    skb_new->protocol = eth_type_trans(skb_new,
    bat_priv->soft_iface);
    - bat_priv->stats.rx_packets++;
    - bat_priv->stats.rx_bytes += skb->len + ETH_HLEN + hdr_size;
    + batadv_inc_counter(bat_priv, BATADV_CNT_RX);
    + batadv_add_counter(bat_priv, BATADV_CNT_RX_BYTES,
    + skb->len + ETH_HLEN + hdr_size);
    bat_priv->soft_iface->last_rx = jiffies;

    netif_rx(skb_new);

    \
     
     \ /
      Last update: 2020-03-19 14:09    [W:4.062 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site