Messages in this thread Patch in this message | | | Subject | Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 | From | Cezary Rojewski <> | Date | Thu, 19 Mar 2020 16:48:03 +0100 |
| |
On 2020-03-19 14:41, Mark Brown wrote: > On Thu, Mar 19, 2020 at 02:00:49PM +0100, Dominik Brodowski wrote: > >> Have some good news now, namely that a bisect is complete: That pointed to >> 1272063a7ee4 ("ASoC: soc-core: care .ignore_suspend for Component suspend"); >> therefore I've added Kuninori Morimoto to this e-mail thread. > > If that's an issue it feels more like a driver bug in that if the driver > asked for ignore_suspend then it should expect not to have the suspend > callback called. >
Requested for tests with following diff applied:
diff --git a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c index db7e1e87156d..6ed4c1b0a515 100644 --- a/sound/soc/intel/boards/broadwell.c +++ b/sound/soc/intel/boards/broadwell.c @@ -212,7 +212,6 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = { .init = broadwell_rt286_codec_init, .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS, - .ignore_suspend = 1, .ignore_pmdown_time = 1, .be_hw_params_fixup = broadwell_ssp0_fixup, .ops = &broadwell_rt286_ops,
| |