lkml.org 
[lkml]   [2020]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drivers/i2c/busses/i2c-imx.c:remove duplicate print after platform_get_irq()
    Date
    We don't need dev_err() message because when something goes wrong,
    platform_get_irq() has print an error message itself, so we should
    remove duplicate dev_err().

    Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
    ---
    drivers/i2c/busses/i2c-imx.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
    index a3b61336f..01fd46682 100644
    --- a/drivers/i2c/busses/i2c-imx.c
    +++ b/drivers/i2c/busses/i2c-imx.c
    @@ -1066,10 +1066,8 @@ static int i2c_imx_probe(struct platform_device *pdev)
    dev_dbg(&pdev->dev, "<%s>\n", __func__);

    irq = platform_get_irq(pdev, 0);
    - if (irq < 0) {
    - dev_err(&pdev->dev, "can't get irq number\n");
    + if (irq < 0)
    return irq;
    - }

    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    base = devm_ioremap_resource(&pdev->dev, res);
    --
    2.20.1.windows.1


    \
     
     \ /
      Last update: 2020-03-18 11:07    [W:3.310 / U:2.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site