Messages in this thread | | | Date | Tue, 17 Mar 2020 09:39:59 -0400 | From | Rodrigo Siqueira <> | Subject | Re: [PATCH] Staging: drm_gem: Fix a misaligned comment block |
| |
Hi Igor,
First of all, thanks for your patch.
Just a few suggestions: * Avoid using "Fix" in this sort of patch. Usually, we use "Fix" for indicating a bug fix or similar. You can read more about it here: https://kernelnewbies.org/PatchPhilosophy * Patch subject format may vary between subsystem, however, I recommend you to follow the instructions from this page: https://www.kernel.org/doc/html/latest/process/submitting-patches.html
In summary, I just recommend you to improve the commit subject for your V2.
Thanks
On 03/16, Igor Matheus Andrade Torrente wrote: > Fix a checkpatch warning caused by a misaligned comment block. > > Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com> > --- > drivers/gpu/drm/drm_gem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > index 000fa4a1899f..6e960d57371e 100644 > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -222,10 +222,10 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj) > return; > > /* > - * Must bump handle count first as this may be the last > - * ref, in which case the object would disappear before we > - * checked for a name > - */ > + * Must bump handle count first as this may be the last > + * ref, in which case the object would disappear before we > + * checked for a name > + */ > > mutex_lock(&dev->object_name_lock); > if (--obj->handle_count == 0) { > -- > 2.20.1 >
-- Rodrigo Siqueira https://siqueira.tech [unhandled content-type:application/pgp-signature] | |