Messages in this thread | | | Date | Tue, 17 Mar 2020 14:38:23 +0100 | From | Borislav Petkov <> | Subject | Re: [patch v3] EDAC: synopsys: Fix the wrong call of pinf->col parameter |
| |
On Mon, Mar 16, 2020 at 09:34:39PM +0800, Sherry Sun wrote: > Since ZynqMP platform call zynqmp_get_error_info() function to get ce/ue > information. In this function, pinf->col parameter is not used, this > parameter is only used by Zynq platforme in zynq_get_error_info(). So > here pinf->col should not be called and printed for ZynqMP, need remove > it. > > In order to show which function called handle_error() explicitly, here > use DDR_ECC_INTR_SUPPORT as check condition to distinguish Zynq and > ZynqMP platform instead the current way. > > Fixes: b500b4a029d57 ("EDAC, synopsys: Add ECC support for ZynqMP DDR controller") > Signed-off-by: Sherry Sun <sherry.sun@nxp.com> > Reviewed-by: Manish Narani <manish.narani@xilinx.com> > --- > Changes in V3: > - Make the check condition in handle_error() more explicitly, use > quirks & DDR_ECC_INTR_SUPPORT instead !quirks, and exchange the context in > if/else. > > Changes in V2: > - Separated this patch from the original patchset. > > --- > drivers/edac/synopsys_edac.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-)
Applied, thanks.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |