Messages in this thread | | | Subject | Re: [PATCH 2/2] tty: serial: qcom_geni_serial: Don't try to manually disable the console | From | Akash Asthana <> | Date | Tue, 17 Mar 2020 18:37:22 +0530 |
| |
On 3/14/2020 2:16 AM, Douglas Anderson wrote: > The geni serial driver's shutdown code had a special case to call > console_stop(). Grepping through the code, it was the only serial > driver doing something like this (the only other caller of > console_stop() was in serial_core.c). > > As far as I can tell there's no reason to call console_stop() in the > geni code. ...and a good reason _not_ to call it. Specifically if > you have an agetty running on the same serial port as the console then > killing the agetty kills your console and if you start the agetty > again the console doesn't come back. > > Fixes: c4f528795d1a ("tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Akash Asthana <akashast@codeaurora.org>
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
| |