Messages in this thread | | | Date | Tue, 17 Mar 2020 11:21:27 +0000 | From | Catalin Marinas <> | Subject | Re: [PATCH v3 05/15] arm64: Don't use disable_nonboot_cpus() |
| |
On Sun, Feb 23, 2020 at 07:29:32PM +0000, Qais Yousef wrote: > disable_nonboot_cpus() is not safe to use when doing machine_down(), > because it relies on freeze_secondary_cpus() which in turn is > a suspend/resume related freeze and could abort if the logic detects any > pending activities that can prevent finishing the offlining process. > > Beside disable_nonboot_cpus() is dependent on CONFIG_PM_SLEEP_SMP which > is an othogonal config to rely on to ensure this function works > correctly. > > Use `reboot_cpu` variable instead of hardcoding 0 as the reboot cpu. > > Signed-off-by: Qais Yousef <qais.yousef@arm.com> > CC: Catalin Marinas <catalin.marinas@arm.com> > CC: Will Deacon <will@kernel.org> > CC: linux-arm-kernel@lists.infradead.org > CC: linux-kernel@vger.kernel.org
I'm not sure whether these patches have been queued already (still unread in my inbox), so here it is:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
| |