| Subject | Re: [PATCH 14/15] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting | From | Christophe Leroy <> | Date | Tue, 17 Mar 2020 12:10:39 +0100 |
| |
Le 09/03/2020 à 09:58, Ravi Bangoria a écrit : > Xmon allows overwriting breakpoints because it's supported by only > one dawr. But with multiple dawrs, overwriting becomes ambiguous > or unnecessary complicated. So let's not allow it.
Could we drop this completely (I mean the functionnality, not the patch).
Christophe
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > --- > arch/powerpc/xmon/xmon.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c > index 0ca0d29f99c6..ac18fe3e4295 100644 > --- a/arch/powerpc/xmon/xmon.c > +++ b/arch/powerpc/xmon/xmon.c > @@ -1381,6 +1381,10 @@ bpt_cmds(void) > printf("Hardware data breakpoint not supported on this cpu\n"); > break; > } > + if (dabr.enabled) { > + printf("Couldn't find free breakpoint register\n"); > + break; > + } > mode = 7; > cmd = inchar(); > if (cmd == 'r') >
|