lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 067/151] s390/qeth: dont reset default_out_queue
    Date
    From: Julian Wiedmann <jwi@linux.ibm.com>

    [ Upstream commit 240c1948491b81cfe40f84ea040a8f2a4966f101 ]

    When an OSA device in prio-queue setup is reduced to 1 TX queue due to
    HW restrictions, we reset its the default_out_queue to 0.

    In the old code this was needed so that qeth_get_priority_queue() gets
    the queue selection right. But with proper multiqueue support we already
    reduced dev->real_num_tx_queues to 1, and so the stack puts all traffic
    on txq 0 without even calling .ndo_select_queue.

    Thus we can preserve the user's configuration, and apply it if the OSA
    device later re-gains support for multiple TX queues.

    Fixes: 73dc2daf110f ("s390/qeth: add TX multiqueue support for OSA devices")
    Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/s390/net/qeth_core_main.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/s390/net/qeth_core_main.c
    +++ b/drivers/s390/net/qeth_core_main.c
    @@ -1244,7 +1244,6 @@ static int qeth_osa_set_output_queues(st
    if (count == 1)
    dev_info(&card->gdev->dev, "Priority Queueing not supported\n");

    - card->qdio.default_out_queue = single ? 0 : QETH_DEFAULT_QUEUE;
    card->qdio.no_out_queues = count;
    return 0;
    }

    \
     
     \ /
      Last update: 2020-03-17 12:10    [W:6.737 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site