lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 100/123] pinctrl: imx: scu: Align imx sc msg structs to 4
    Date
    From: Leonard Crestez <leonard.crestez@nxp.com>

    commit 4c48e549f39f8ed10cf8a0b6cb96f5eddf0391ce upstream.

    The imx SC api strongly assumes that messages are composed out of
    4-bytes words but some of our message structs have odd sizeofs.

    This produces many oopses with CONFIG_KASAN=y.

    Fix by marking with __aligned(4).

    Fixes: b96eea718bf6 ("pinctrl: fsl: add scu based pinctrl support")
    Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
    Link: https://lore.kernel.org/r/bd7ad5fd755739a6d8d5f4f65e03b3ca4f457bd2.1582216144.git.leonard.crestez@nxp.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/pinctrl/freescale/pinctrl-scu.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/pinctrl/freescale/pinctrl-scu.c
    +++ b/drivers/pinctrl/freescale/pinctrl-scu.c
    @@ -23,12 +23,12 @@ struct imx_sc_msg_req_pad_set {
    struct imx_sc_rpc_msg hdr;
    u32 val;
    u16 pad;
    -} __packed;
    +} __packed __aligned(4);

    struct imx_sc_msg_req_pad_get {
    struct imx_sc_rpc_msg hdr;
    u16 pad;
    -} __packed;
    +} __packed __aligned(4);

    struct imx_sc_msg_resp_pad_get {
    struct imx_sc_rpc_msg hdr;

    \
     
     \ /
      Last update: 2020-03-17 12:05    [W:4.049 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site