lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 057/123] net: phy: Avoid multiple suspends
    Date
    From: Florian Fainelli <f.fainelli@gmail.com>

    commit 503ba7c6961034ff0047707685644cad9287c226 upstream.

    It is currently possible for a PHY device to be suspended as part of a
    network device driver's suspend call while it is still being attached to
    that net_device, either via phy_suspend() or implicitly via phy_stop().

    Later on, when the MDIO bus controller get suspended, we would attempt
    to suspend again the PHY because it is still attached to a network
    device.

    This is both a waste of time and creates an opportunity for improper
    clock/power management bugs to creep in.

    Fixes: 803dd9c77ac3 ("net: phy: avoid suspending twice a PHY")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/phy/phy_device.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/drivers/net/phy/phy_device.c
    +++ b/drivers/net/phy/phy_device.c
    @@ -246,7 +246,7 @@ static bool mdio_bus_phy_may_suspend(str
    * MDIO bus driver and clock gated at this point.
    */
    if (!netdev)
    - return !phydev->suspended;
    + goto out;

    if (netdev->wol_enabled)
    return false;
    @@ -266,7 +266,8 @@ static bool mdio_bus_phy_may_suspend(str
    if (device_may_wakeup(&netdev->dev))
    return false;

    - return true;
    +out:
    + return !phydev->suspended;
    }

    static int mdio_bus_phy_suspend(struct device *dev)

    \
     
     \ /
      Last update: 2020-03-17 12:03    [W:4.442 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site