lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 027/123] sfc: detach from cb_page in efx_copy_channel()
    Date
    From: Edward Cree <ecree@solarflare.com>

    [ Upstream commit 4b1bd9db078f7d5332c8601a2f5bd43cf0458fd4 ]

    It's a resource, not a parameter, so we can't copy it into the new
    channel's TX queues, otherwise aliasing will lead to resource-
    management bugs if the channel is subsequently torn down without
    being initialised.

    Before the Fixes:-tagged commit there was a similar bug with
    tsoh_page, but I'm not sure it's worth doing another fix for such
    old kernels.

    Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2")
    Suggested-by: Derek Shute <Derek.Shute@stratus.com>
    Signed-off-by: Edward Cree <ecree@solarflare.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/sfc/efx.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/sfc/efx.c
    +++ b/drivers/net/ethernet/sfc/efx.c
    @@ -519,6 +519,7 @@ efx_copy_channel(const struct efx_channe
    if (tx_queue->channel)
    tx_queue->channel = channel;
    tx_queue->buffer = NULL;
    + tx_queue->cb_page = NULL;
    memset(&tx_queue->txd, 0, sizeof(tx_queue->txd));
    }


    \
     
     \ /
      Last update: 2020-03-17 12:01    [W:4.095 / U:0.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site