lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Input: edt-ft5x06 - add fw_version debugfs file to read
From
Date
On 16.03.20 15:40, Andy Shevchenko wrote:
> On Mon, Mar 16, 2020 at 03:27:56PM +0100, Martin Kepplinger wrote:
>> Add simple fw_version file in debugfs to read the value from 0xa6
>> which is the firmware version.
>
>
> If you switch to regmap I²C API you will get this for free for all defined
> registers.
>
> So, I highly recommend to consider above.
>

I don't know all the devices and modes well enough if the current raw
read/write buffers always translate to (only) buf[0] being the register
address.

If you tell me I can assume just that, I'm happy to do a larger change
that completely does aways with the current raw buffers.

Otherwise:

Does is make sense to *add* just a few regmap calls but keep the current
i2c_transfer in place for the calls I'm not sure about? I could do that
in any case.

thanks!

martin

\
 
 \ /
  Last update: 2020-03-17 11:28    [W:0.044 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site