lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 3/3] mmc: host: sdhci-sprd: Implement the request_atomic() API
    Date
    Implement the request_atomic() API for nonremovable cards, that means
    we can submit next request in the irq hard handler context to reduce
    latency.

    Moreover factor out the AUTO CMD23 checking into a separate function
    to reduce duplicate code.

    Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
    ---
    drivers/mmc/host/sdhci-sprd.c | 23 ++++++++++++++++++++---
    1 file changed, 20 insertions(+), 3 deletions(-)

    diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
    index 2ab42c5..9a08f70 100644
    --- a/drivers/mmc/host/sdhci-sprd.c
    +++ b/drivers/mmc/host/sdhci-sprd.c
    @@ -406,7 +406,8 @@ static void sdhci_sprd_request_done(struct sdhci_host *host,
    .request_done = sdhci_sprd_request_done,
    };

    -static void sdhci_sprd_request(struct mmc_host *mmc, struct mmc_request *mrq)
    +static void sdhci_sprd_check_auto_cmd23(struct mmc_host *mmc,
    + struct mmc_request *mrq)
    {
    struct sdhci_host *host = mmc_priv(mmc);
    struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host);
    @@ -422,10 +423,23 @@ static void sdhci_sprd_request(struct mmc_host *mmc, struct mmc_request *mrq)
    mrq->sbc && (mrq->sbc->arg & SDHCI_SPRD_ARG2_STUFF) &&
    (host->flags & SDHCI_AUTO_CMD23))
    host->flags &= ~SDHCI_AUTO_CMD23;
    +}
    +
    +static void sdhci_sprd_request(struct mmc_host *mmc, struct mmc_request *mrq)
    +{
    + sdhci_sprd_check_auto_cmd23(mmc, mrq);

    sdhci_request(mmc, mrq);
    }

    +static void sdhci_sprd_request_atomic(struct mmc_host *mmc,
    + struct mmc_request *mrq)
    +{
    + sdhci_sprd_check_auto_cmd23(mmc, mrq);
    +
    + sdhci_request_atomic(mmc, mrq);
    +}
    +
    static int sdhci_sprd_voltage_switch(struct mmc_host *mmc, struct mmc_ios *ios)
    {
    struct sdhci_host *host = mmc_priv(mmc);
    @@ -561,6 +575,11 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
    if (ret)
    goto pltfm_free;

    + if (!mmc_card_is_removable(host->mmc))
    + host->mmc_host_ops.request_atomic = sdhci_sprd_request_atomic;
    + else
    + host->always_defer_done = true;
    +
    sprd_host = TO_SPRD_HOST(host);
    sdhci_sprd_phy_param_parse(sprd_host, pdev->dev.of_node);

    @@ -654,8 +673,6 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
    if (ret)
    goto err_cleanup_host;

    - host->always_defer_done = true;
    -
    ret = __sdhci_add_host(host);
    if (ret)
    goto err_cleanup_host;
    --
    1.9.1
    \
     
     \ /
      Last update: 2020-03-17 11:15    [W:2.340 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site