| Date | Tue, 17 Mar 2020 16:05:03 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v2 00/19] objtool: vmlinux.o and noinstr validation |
| |
On Tue, Mar 17, 2020 at 06:02:34PM +0100, Peter Zijlstra wrote: > Hi all, > > Moar patches. This implements the proposed objtool validation for the > > noinstr -- function attribute > instr_{begin,end}() -- annotation > > Who's purpose is to annotate such code that has constraints on instrumentation > -- such as early exception code. Specifically it makes it very hard to > accidentally add code to such regions. > > I've left the whole noinstr naming in place, we'll bike-shed on that later. > > This should address all feedback from RFC/v1.
Looks good to me, other than a few minor comments on patch 16.
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
-- Josh
|