lkml.org 
[lkml]   [2020]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/2] ASoC: fsl: Add generic CPU DAI driver
From
Date
On 3/6/20 12:13 PM, Daniel Baluta wrote:
> +static int fsl_dai_probe(struct platform_device *pdev)
> +{
> [...]
> + ret = of_property_read_u32(np, "fsl,dai-index", &dai_index);
> + if (ret) {
> + dev_err(&pdev->dev, "dai-index missing or invalid\n");
> + return ret;
> + }
Maybe this can follow a more standard approach using DT aliases. Just
like we assign IDs to things like SPI or I2C masters.
> +
> + fsl_dai.name = dai_name;
This breaks as soon as there is more than one DAI in the system since
you are sharing a global struct between them.
[...]

\
 
 \ /
  Last update: 2020-03-16 16:11    [W:0.055 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site