Messages in this thread | | | Date | Sun, 15 Mar 2020 11:18:31 -0500 | From | Josh Poimboeuf <> | Subject | Re: [RFC][PATCH 05/16] objtool: Optimize find_symbol_by_index() |
| |
On Sun, Mar 15, 2020 at 11:09:19AM -0500, Josh Poimboeuf wrote: > On Thu, Mar 12, 2020 at 02:41:12PM +0100, Peter Zijlstra wrote: > > The symbol index is object wide, not per section, so it makes no sense > > to have the symbol_hash be part of the section object. By moving it to > > the elf object we avoid the linear sections iteration. > > I remember there was a specific reason for this oddity, but it eludes me > now. > > This does make sense, assuming it doesn't break anything.
On second thought I guess it was the symbol_list which had this intentional per-section structure (for a still unremembered reason).
Then the symbol_hash came later, and it just parroted the symbol_list structure. So yeah, this change should be fine.
-- Josh
| |