Messages in this thread | | | Date | Sat, 14 Mar 2020 21:02:46 -0700 (PDT) | Subject | Re: [PATCH v2] net/bpfilter: fix dprintf usage for /dev/kmsg | From | David Miller <> |
| |
From: Bruno Meneguele <bmeneg@redhat.com> Date: Thu, 12 Mar 2020 20:08:20 -0300
> The bpfilter UMH code was recently changed to log its informative messages to > /dev/kmsg, however this interface doesn't support SEEK_CUR yet, used by > dprintf(). As result dprintf() returns -EINVAL and doesn't log anything. > > However there already had some discussions about supporting SEEK_CUR into > /dev/kmsg interface in the past it wasn't concluded. Since the only user of > that from userspace perspective inside the kernel is the bpfilter UMH > (userspace) module it's better to correct it here instead waiting a conclusion > on the interface. > > Fixes: 36c4357c63f3 ("net: bpfilter: print umh messages to /dev/kmsg") > Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Applied, thank you.
| |