Messages in this thread | | | Date | Sat, 14 Mar 2020 15:20:19 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 03/16] soundwire: cadence: add interface to check clock status |
| |
On 13-03-20, 11:31, Pierre-Louis Bossart wrote: > > > > > +/** > > > + * sdw_cdns_is_clock_stop: Check clock status > > > + * > > > + * @cdns: Cadence instance > > > + */ > > > +bool sdw_cdns_is_clock_stop(struct sdw_cdns *cdns) > > > +{ > > > + u32 status; > > > + > > > + status = cdns_readl(cdns, CDNS_MCP_STAT) & CDNS_MCP_STAT_CLK_STOP; > > > + if (status) { > > > + dev_dbg(cdns->dev, "Clock is stopped\n"); > > > + return true; > > > + } > > > > This can be further optimized to: > > > > return !!(cdns_readl(cdns, CDNS_MCP_STAT) & CDNS_MCP_STAT_CLK_STOP); > > The logs are very useful for debug.
You have this log also in caller function.
-- ~Vinod
| |