Messages in this thread | | | Date | Sat, 14 Mar 2020 17:38:39 +0100 | From | Lubomir Rintel <> | Subject | Re: [PATCH] phy: Add USB HSIC PHY driver for Marvell MMP3 SoC |
| |
On Fri, Mar 13, 2020 at 04:52:00PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On 09/03/20 6:28 pm, Lubomir Rintel wrote: > > Add PHY driver for the HSICs found on Marvell MMP3 SoC. The driver is > > rather straightforward -- the PHY essentially just needs to be enabled. > > > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > > --- > > drivers/phy/marvell/Kconfig | 12 +++++ > > drivers/phy/marvell/Makefile | 1 + > > drivers/phy/marvell/phy-mmp3-hsic.c | 82 +++++++++++++++++++++++++++++ > > 3 files changed, 95 insertions(+) > > create mode 100644 drivers/phy/marvell/phy-mmp3-hsic.c > > ... > > diff --git a/drivers/phy/marvell/phy-mmp3-hsic.c b/drivers/phy/marvell/phy-mmp3-hsic.c > > new file mode 100644 > > index 0000000000000..f7b430f6f6f05 > > --- /dev/null > > +++ b/drivers/phy/marvell/phy-mmp3-hsic.c ... > > +static const struct of_device_id mmp3_hsic_phy_of_match[] = { > > + { .compatible = "marvell,mmp3-hsic-phy", }, > > Where is the binding documentation for this?
There's one in mainline: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
It got added just to document the compatible string at the time I thought usb-nop-xceiv would be sufficient to support the hardware.
It needs some fixing -- the "reset-gpios" shouldn't be there. I'll follow up with a patch that removes it; please let me know if anything else needs to be fixed there.
> Thanks > Kishon
Thank you, Lubo
| |