Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 06/10] KVM: nVMX: Convert local exit_reason to u16 in ...enter_non_root_mode() | Date | Fri, 13 Mar 2020 14:00:56 +0000 |
| |
From: Vitaly Kuznetsov > Sent: 13 March 2020 13:56 ... > > load_vmcs12_host_state(vcpu, vmcs12); > > - vmcs12->vm_exit_reason = exit_reason | VMX_EXIT_REASONS_FAILED_VMENTRY; > > + vmcs12->vm_exit_reason = VMX_EXIT_REASONS_FAILED_VMENTRY | exit_reason; > > My personal preference would be to do > (u32)exit_reason | VMX_EXIT_REASONS_FAILED_VMENTRY > instead but maybe I'm just not in love with implicit type convertion in C.
I look at the cast and wonder what is going on :-)
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |