Messages in this thread | | | Subject | Re: [PATCH 6/6] hantro: Refactor for V4L2 API spec compliancy | From | Ezequiel Garcia <> | Date | Wed, 11 Mar 2020 16:01:44 -0300 |
| |
On Wed, 2020-03-11 at 14:43 -0300, Ezequiel Garcia wrote: > Refactor how S_FMT and TRY_FMT are handled, and also make sure > internal initial format and format reset are done properly. > > The latter is achieved by making sure the same hantro_{set,try}_fmt > helpers are called on all paths that set the format (which is > part of the driver state). > > This commit removes the following v4l2-compliance warnings: > > test VIDIOC_G_FMT: OK > fail: v4l2-test-formats.cpp(711): Video Capture Multiplanar: TRY_FMT(G_FMT) != G_FMT > test VIDIOC_TRY_FMT: FAIL > fail: v4l2-test-formats.cpp(1116): Video Capture Multiplanar: S_FMT(G_FMT) != G_FMT > test VIDIOC_S_FMT: FAIL > > Reported-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > --- [..] > @@ -227,12 +232,12 @@ static int vidioc_g_fmt_cap_mplane(struct file *file, void *priv, > return 0; > } > > -static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f, > - bool capture) > +static int hantro_try_fmt(const struct hantro_ctx *ctx,
Oops, it seems there's a warning due to ctx being const-qualified.
That should be fixed of course.
Regards, Ezequiel
| |