Messages in this thread | | | From | Vineet Gupta <> | Subject | Re: [PATCH 1/2] ARC: define __ALIGN_STR and __ALIGN symbols for ARC | Date | Wed, 11 Mar 2020 16:35:40 +0000 |
| |
On 3/11/20 9:26 AM, Eugeniy Paltsev wrote: > As of today ARC uses generic __ALIGN_STR and __ALIGN symbol > definitions from "include/linux/linkage.h" > They are defined to ".align 4,0x90" which instructed the assembler > to use `0x90` as a fill byte when aligning functions declared with > ENTRY or similar macroses. This leads to generated weird instructions > in code (when alignment is used) like "ldh_s r12,[r0,0x20]" which is > encoded as 0x9090 for ARCv2. > > Let's use ".align 4" which insert a "nop_s" instruction instead. > > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Acked-by: Vineet Gupta <vgupta@synopsys.com>
-Vineet
| |