Messages in this thread | | | Date | Wed, 11 Mar 2020 17:15:51 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] device core: fix dma_mask handling in platform_device_register_full |
| |
On Wed, Mar 11, 2020 at 05:14:23PM +0100, Greg KH wrote: > On Wed, Mar 11, 2020 at 05:07:10PM +0100, Christoph Hellwig wrote: > > Ever since the generic platform device code started allocating DMA masks > > itself the code to allocate and leak a private DMA mask in > > platform_device_register_full has been superflous. More so the fact that > > it unconditionally frees the DMA mask allocation in the failure path > > can lead to slab corruption if the function fails later on for a device > > where it didn't allocate the mask. Just remove the offending code. > > > > Fixes: cdfee5623290 ("driver core: initialize a default DMA mask for platform device") > > Reported-by: Artem S. Tashkinov <aros@gmx.com> > > Tested-by: Artem S. Tashkinov <aros@gmx.com> > > No s-o-b from you? :( > > I can take this, or Linus, you can take this now if you want to as well:
Sorry, here it is:
Signed-off-by: Christoph Hellwig <hch@lst.de>
| |